headerbar: Don't leak widgets
authorMatthias Clasen <mclasen@redhat.com>
Thu, 10 Nov 2016 20:03:16 +0000 (15:03 -0500)
committerMatthias Clasen <mclasen@redhat.com>
Thu, 10 Nov 2016 20:03:35 +0000 (15:03 -0500)
We were not properly freeing separators that we end up
not using.

https://bugzilla.gnome.org/show_bug.cgi?id=774066

gtk/gtkheaderbar.c

index 592abe3d53a48a145d96a08bb15f275024ad7252..e630432b2e93eb00f71c45230ad71a35d383af0e 100644 (file)
@@ -458,8 +458,10 @@ _gtk_header_bar_update_window_buttons (GtkHeaderBar *bar)
 
           if (n_children == 0)
             {
-              gtk_widget_destroy (box);
-              gtk_widget_destroy (separator);
+              g_object_ref_sink (box);
+              g_object_unref (box);
+              g_object_ref_sink (separator);
+              g_object_unref (separator);
               continue;
             }